On 8/5/25 11:15, Jan Beulich wrote: > On 04.08.2025 19:33, Dmytro Prokopchuk1 wrote: >> MISRA Rule 16.4: Every switch statement shall have a default label. >> The default clause must contain either a statement or a comment >> prior to its terminating break statement. >> >> However, there is a documented deviation for this rule in Xen: >> 'docs/misra/deviations.rst': >> * - R16.4 >> - A switch statement with a single clause and no default label >> may replace an equivalent if statement to improve readability. >> - Tagged as `deliberate` for ECLAIR. >> >> This change removes empty default cases in single-clause switches >> to avoid violations of the rule where the `default` clause lacks >> a suitable comment or statement. >> >> Signed-off-by: Dmytro Prokopchuk <dmytro_prokopch...@epam.com> > > It's all CPU notifiers that you alter, and iirc the outcome of earlier > discussion was that particularly for those we _want_ to add commentary, > clarifying why only the given subset of notification need handling in > the particular case. It may also well be that the (at least) one case > of the possibly missing handling of some other notification still is > unaddressed (and might hence be wrongly hidden by the adjustment done > here, if it's in one of the function that are being altered). > > Jan
I understood. Thank you, Jan. Dmytro
