On 13.08.2025 13:13, Andrew Cooper wrote:
> On 12/08/2025 9:41 am, Jan Beulich wrote:
>> On 08.08.2025 22:23, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/acpi/wakeup_prot.S
>>> +++ b/xen/arch/x86/acpi/wakeup_prot.S
>>> @@ -63,6 +63,9 @@ LABEL(s3_resume)
>>>          pushq   %rax
>>>          lretq
>>>  1:
>>> +        /* Set up early exceptions and CET before entering C properly. */
>>> +        call    ap_early_traps_init
>> But this is the BSP?
> 
> By the end of the cleanup, what we have is:
> 
> At boot only:
>  * really early init, basic exception handling only
>  * regular init (inc syscall trampolines)
>  * late re-init as we change the stack linear address
> 
> For everything else (APs, S3, hot-online):
>  * early, full exception handling
>  * regular init (inc syscall trampolines)
> 
> 
> Currently, these are named:
>  * bsp_early_traps_init()
>  * traps_init()
>  * bsp_traps_reinit()
> 
> and
>  * ap_early_traps_init()
>  * percpu_traps_init()
> 
> 
> Perhaps ap_early_traps_init() should be named
> percpu_early_traps_init()?  But I'm open to suggestions.

That name looks like a better fit to me, yes.

Jan

Reply via email to