On 19.08.2025 21:45, Andrew Cooper wrote:
> On 19/08/2025 1:04 pm, Jan Beulich wrote:
>> On 15.08.2025 22:41, Andrew Cooper wrote:
>>> --- a/xen/arch/x86/tsx.c
>>> +++ b/xen/arch/x86/tsx.c
>>> @@ -42,6 +42,8 @@ void tsx_init(void)
>>> {
>>> static bool __read_mostly once;
>>>
>>> + uint64_t val;
>>> +
>>> /*
>> No real need for yet another newline, I would say.
>
> Where? Before? that's separation of static and not. After? that's
> separation of variables and code. All as we do elsewhere.
The latter we do elsewhere too, sure. But separating statics from auto
variables we don't normally do, unless the set of declarations is rather
large.
Jan
