[Public]
> -----Original Message-----
> From: Anthony PERARD <anth...@xenproject.org>
> Sent: Wednesday, August 27, 2025 11:22 PM
> To: Penny, Zheng <penny.zh...@amd.com>
> Cc: xen-devel@lists.xenproject.org; Huang, Ray <ray.hu...@amd.com>; Anthony
> PERARD <anthony.per...@vates.tech>; Juergen Gross <jgr...@suse.com>;
> Andrew Cooper <andrew.coop...@citrix.com>; Orzel, Michal
> <michal.or...@amd.com>; Jan Beulich <jbeul...@suse.com>; Julien Grall
> <jul...@xen.org>; Roger Pau Monné <roger....@citrix.com>; Stefano Stabellini
> <sstabell...@kernel.org>
> Subject: Re: [PATCH v7 11/13] tools/cpufreq: extract CPPC para from cpufreq
> para
>
> On Fri, Aug 22, 2025 at 06:52:16PM +0800, Penny Zheng wrote:
> > diff --git a/tools/misc/xenpm.c b/tools/misc/xenpm.c index
> > 6b054b10a4..8fc1d7cc65 100644
> > --- a/tools/misc/xenpm.c
> > +++ b/tools/misc/xenpm.c
> > @@ -898,6 +900,23 @@ static void print_cpufreq_para(int cpuid, struct
> xc_get_cpufreq_para *p_cpufreq)
> > printf("\n");
> > }
> >
> > +/* show cpu cppc parameters information on CPU cpuid */ static int
> > +show_cppc_para_by_cpuid(xc_interface *xc_handle, unsigned int cpuid)
> > +{
> > + int ret;
> > + xc_cppc_para_t cppc_para;
> > +
> > + ret = xc_get_cppc_para(xc_handle, cpuid, &cppc_para);
> > + if ( !ret )
> > + print_cppc_para(cpuid, &cppc_para);
> > + else if ( errno == ENODEV )
> > + ret = 0; /* Ignore unsupported platform */
> > + else
> > + fprintf(stderr, "[CPU%u] failed to get cppc parameter\n",
> > + cpuid);
>
> You might want to add ": %s" strerror(errno) to the error printed, which
> could help
> figure out why we failed to get the parameters.
>
Ack
>
> The rest of the tool side of the patch, with Jan suggestion, looks good to
> me, so
> Acked-by: Anthony PERARD <anthony.per...@vates.tech> for the next round.
>
Thanks
> Thanks,
>
> --
> Anthony PERARD
