On 28.08.2025 03:16, Jason Andryuk wrote: > On 2025-08-27 01:57, Jan Beulich wrote: >> Callers observing errors elsewhere may be confused by the ENOSYS that >> the Flask operation would yield on a Flask-disabled hypervisor. >> >> Signed-off-by: Jan Beulich <jbeul...@suse.com> >> --- >> Of course I don't know whether clobbering errno is perhaps deemed "fine" >> in libxl. > > I wonder if it would be better to special case > libxl_flask_sid_to_context() to preserve errno on ENOSYS. flask > returning ENOSYS is common, but libxl_flask_sid_to_context() can > legitimately have error.
But then libxl__xcinfo2xlinfo() also shouldn't (effectively) ignore such other errors? Question is what it should do in such an event. > I guess this is fine if we want to use this approach: > > Reviewed-by: Jason Andryuk <jason.andr...@amd.com> Thanks. Jan
