On Wed, Sep 03, 2025 at 06:06:01PM +0200, Anthony PERARD wrote: > Hi Jahan, > > On Wed, Sep 03, 2025 at 03:53:19PM +0530, Jahan Murudi wrote: > > This is v4 of the patch series to add physical CPU monitoring to xentop. > > > > Changes since v3: > > - Split the single large patch into a logical series of 3 smaller patches > > for easier review. > > The single patch in v3 was fine to review. It didn't really need to be > cut into several patches. Having one file change per patch is certainly > the worse possible way to cut one patch into several. > > It might have been possible to separate into several patch in another > way, but it's a bit too late for that, there's already been several > reviews. What I like to do when I review a patch series, is to look at > the difference since the last review I gave, tools like > `git range-diff` and https://patchew.org/Xen/ can help with that. > > Anyway, squashing back all the patch is the way to go I think. > > I'll have a look at the changes.
So the code looks good, but only if it is a single patch like on v3. Would you be fine if I merge the change, but squash all patch of v4 together and take the patch description from v3? (or the patch description of the last patch with "integrate" replace by "introduce".) If I do the squashing, I'll just ignore the remark to use "unsigned int" instead of "int". With all patch squash together, more or less: Reviewed-by: Anthony PERARD <anthony.per...@vates.tech> Cheers, -- Anthony PERARD
