On 08.09.2025 10:29, Mykola Kvach wrote: > On Sat, Sep 6, 2025 at 2:27 AM <dmuk...@xen.org> wrote: >> --- /dev/null >> +++ b/xen/common/emul/vuart/Kconfig >> @@ -0,0 +1,6 @@ >> +config VUART_FRAMEWORK >> + bool > > If VUART_FRAMEWORK has no dependencies, it can be enabled on any > architecture. For example, I tried enabling it on arm64 and the build > fails: > > ./include/xen/vuart.h:26:8: error: redefinition of ‘struct vuart’ > > Should this config be restricted (e.g. "depends on X86") or the code > adjusted to handle non-x86 architectures properly?
"depends on" isn't very useful when there's no prompt. An arch selecting such an option will need to make sure things actually build when enabled. Jan
