On Thu Sep 11, 2025 at 10:24 AM CEST, Gerald Elder-Vass wrote: > Commit cb41b4ce14a9 introduced init_secure_boot_mode but one line was > not wrapped appropriately. > > Signed-off-by: Gerald Elder-Vass <gerald.elder-v...@cloud.com> > --- > CC: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com> > CC: "Daniel P. Smith" <dpsm...@apertussolutions.com> > CC: Jan Beulich <jbeul...@suse.com> > CC: Andrew Cooper <andrew.coop...@citrix.com> > CC: Anthony PERARD <anthony.per...@vates.tech> > CC: Michal Orzel <michal.or...@amd.com> > CC: Julien Grall <jul...@xen.org> > CC: "Roger Pau Monné" <roger....@citrix.com> > CC: Stefano Stabellini <sstabell...@kernel.org> > --- > xen/common/efi/boot.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > index b86c83d3348c..69fc022c18ab 100644 > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -923,7 +923,8 @@ static void __init init_secure_boot_mode(void) > > if ( status == EFI_NOT_FOUND || > (status == EFI_SUCCESS && > - attr == (EFI_VARIABLE_BOOTSERVICE_ACCESS | > EFI_VARIABLE_RUNTIME_ACCESS) && > + attr == (EFI_VARIABLE_BOOTSERVICE_ACCESS | > + EFI_VARIABLE_RUNTIME_ACCESS) && > size == 1 && data == 0) ) > /* Platform does not support Secure Boot or it's disabled. */ > efi_secure_boot = false;
You're not wrong, but it feels a bit excessive having a patch just for this. Oh, well. Reviewed-by: Alejandro Vallejo <alejandro.garciavall...@amd.com> Cheers, Alejandro
