On 08.09.2025 11:35, Gerald Elder-Vass wrote: >>> + size == 1 && data == 0) ) >> >> ... any reason it's literal 1 here? > > The size variable is also used as output from GetVariable and we should > verify that the size of the returned data is as expected, it is simply one > byte so probably not worth defining any macros to make it clearer
I don't understand this reply. Why would the initializer of the variable use one thing (sizeof()) and the checking of the variable another (literal 1)? Even consistently using 1 would already be better imo; consistently using sizeof() is what I think would be best. Jan
