On 10.09.2025 09:38, Penny Zheng wrote:
> Wrap domctl hypercall def and domctl.o with CONFIG_MGMT_HYPERCALLS,
> and remove all #ifdef CONFIG_MGMT_HYPERCALLS wrappings in common/domctl.c
> With MGMT_HYPERCALLS=n, we need to provide stub for
> domctl_lock_{acquire,release}(), as it may be invoked by hvm_set_param().
>
> Signed-off-by: Penny Zheng <[email protected]>
> ---
> v1 -> v2:
> - remove stub in common/domctl.c
> - combine the original commit of "xen/domctl: provide stub for
> domctl_lock_{acquire,release}"
> - adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS"
> ---
> xen/common/Kconfig | 2 +-
> xen/common/Makefile | 2 +-
> xen/common/domctl.c | 24 ------------------------
> xen/include/hypercall-defs.c | 4 +++-
> xen/include/xen/domain.h | 9 +++++++++
> 5 files changed, 14 insertions(+), 27 deletions(-)
Please see all the removals of #ifdef-s below for why I was arguing towards
the Kconfig control wanting to (re)gain its prompt last. These #ifdef-s will
have been added by earlier patches in the series (which I didn't look at
yet), and that kind of churn could have been avoided.
Jan
