On 25.09.2025 10:14, Oleksii Moisieiev wrote:
> 
> 
> On 25/09/2025 09:34, Jan Beulich wrote:
>> On 24.09.2025 18:00, Oleksii Moisieiev wrote:
>>> --- a/xen/common/Kconfig
>>> +++ b/xen/common/Kconfig
>>> @@ -26,6 +26,14 @@ config DOM0LESS_BOOT
>>>       Xen boot without the need of a control domain (Dom0), which could be
>>>       present anyway.
>>>   
>>> +config DOM0_BOOT
>>> +   bool "Dom0 boot support" if EXPERT
>>> +   default y
>>> +   depends on (ARM && HAS_DOM0 && HAS_DEVICE_TREE_DISCOVERY && 
>>> DOMAIN_BUILD_HELPERS) || (X86 && HAS_DOM0)
>> This line is too long, and really would have wanted to be broken up anyway. 
>> Clearly
>> "depends on HAS_DOM0" can be separated out. I'm not quite sure about the 
>> extra
>> Arm-specific dependencies: Are these two really Arm-only (as in: not also 
>> affecting
>> e.g. RISC-V)? Furthermore, what if I turned this option off for x86? Doing 
>> so would,
>> aiui, have no effect at all right now. An option without any effect imo 
>> better
>> wouldn't be exposed.
> My intention was to introduce same behavior for both x86 and arm.
> Added this config parameter as was stated in the following reply for v1 [0]

No. What I said was "Imo at this point x86 should have this option set to Y
unconditionally." That's not what the above construct does.

Jan

> For now, since hyperlaunch is not merged yet the only option for x86 is 
> Dom0 so it will
> take no effect for x86 right now.
> 
> [0]https://lore.kernel.org/xen-devel/[email protected]/
>> Jan


Reply via email to