Function domain_set_node_affinity() is responsible for XEN_DOMCTL_setnodeaffinity domctl-op, and shall be wrapped with CONFIG_MGMT_HYPERCALLS. Otherwise it will become unreachable codes when MGMT_HYPERCALLS=n, and hence violating Misra rule 2.1.
Signed-off-by: Penny Zheng <[email protected]> Reviewed-by: Stefano Stabellini <[email protected]> --- v1 -> v2: - adapt to changes of "unify DOMCTL to MGMT_HYPERCALLS" - wrap XEN_DOMCTL_setnodeaffinity-case and xenctl_bitmap_to_nodemask() transiently --- v2 -> v3: - address "violating Misra rule 2.1" in commit message - remove transient wrapping around XEN_DOMCTL_setnodeaffinity-case --- xen/common/domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/domain.c b/xen/common/domain.c index 5d81ab3045..6778dc388c 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1105,6 +1105,7 @@ void __init setup_system_domains(void) #endif } +#ifdef CONFIG_MGMT_HYPERCALLS int domain_set_node_affinity(struct domain *d, const nodemask_t *affinity) { /* Being disjoint with the system is just wrong. */ @@ -1133,6 +1134,7 @@ out: return 0; } +#endif /* CONFIG_MGMT_HYPERCALLS */ /* rcu_read_lock(&domlist_read_lock) must be held. */ static struct domain *domid_to_domain(domid_t dom) -- 2.34.1
