On 2025-10-06 01:59, Juergen Gross wrote:
Declarations of xc_dom_console_init() and xc_dom_console_set_disconnected() in libxenguest.h don't match their implementation in the library.Under arm32, xen_pfn_t is a uint64_t and wider than unsigned long. Use xen_pfn_t for GFNs in the library to fix that. At the same time change the parameter name of the implementation to console_gfn, matching the interface declaration in the header and reality (it is a GFN, not a PFN). Fixes: b6fc307b0b00 ("libs/guest: Set console as disconnected on resume") Fixes: 971b7d5ecbcd ("libs/guest: Set console page to disconnected") Reported-by: Luca Fancellu <[email protected]> Signed-off-by: Juergen Gross <[email protected]> --- V2: - switch parameter name as well (Andrew Cooper)
Thanks for doing this. I ran the original series through CI, but didn't know that omits an arm32 toolstack build.
I see it's already in the tree, but here's an after-the-fact: Reviewed-by: Jason Andryuk <[email protected]> Thanks again, Jason
