On 22.10.2025 15:56, Mykyta Poturai wrote: > From: Stefano Stabellini <[email protected]> > > has_vpci_bridge is a macro to check if the domain is a domU or is dom0 > with vPCI (pci-scan=yes) enabled. > > Use the macro in drivers/vpci. > > Signed-off-by: Stefano Stabellini <[email protected]> > Signed-off-by: Stewart Hildebrand <[email protected]> > Signed-off-by: Mykyta Poturai <[email protected]> > --- > v1->v2: > * simplify definition > --- > xen/drivers/vpci/header.c | 14 +++++++------- > xen/drivers/vpci/vpci.c | 4 ++-- > xen/include/xen/vpci.h | 8 ++++++++ > 3 files changed, 17 insertions(+), 9 deletions(-)
With this diffstat, its the subject prefix missing a 'v' (xen/vpci:)? > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -230,7 +230,7 @@ bool vpci_process_pending(struct vcpu *v) > > read_unlock(&v->domain->pci_lock); > > - if ( !is_hardware_domain(v->domain) ) > + if ( has_vpci_bridge(v->domain) ) > domain_crash(v->domain); Here and perhaps everywhere else I wonder: Is this really an appropriately named predicate for the purpose / context? Jan
