On 10/27/25 10:50, Jan Beulich wrote: > On 26.10.2025 22:37, Julien Grall wrote: >> Hi Jan, >> >> On 24/10/2025 08:43, Jan Beulich wrote: >>> On 23.10.2025 20:00, Dmytro Prokopchuk1 wrote: >>>> --- a/xen/arch/arm/efi/efi-boot.h >>>> +++ b/xen/arch/arm/efi/efi-boot.h >>>> @@ -227,6 +227,7 @@ static EFI_STATUS __init >>>> efi_process_memory_map_bootinfo(EFI_MEMORY_DESCRIPTOR * >>>> } >>>> } >>>> #endif >>>> + /* SAF-15-safe casting a pointer */ >>>> desc_ptr = NextMemoryDescriptor(desc_ptr, desc_size); >>>> } >>>> >>> >>> While at present we have only one use site, needing per-use-site comments >>> isn't very nice. Putting it into the imported header isn't nice either. >>> Could Arm perhaps get away without using the macro, just like x86 manages >>> to? >> >> >> IIUC, you mean something like: >> >> EFI_MEMORY_DESCRIPTOR *desc = efi_memmap + i; >> >> If so, this would work for me. > > Right, provided that efi_memmap is of type void * or const void *. > > Jan
Thank you for the advice. I'll prepare v2. Dmytro.
