On 10.11.2025 13:30, Frediano Ziglio wrote: > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -228,17 +228,23 @@ endif > $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o > $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds $< \ > $(dot-target).1r.o $(dot-target).1s.o $(orphan-handling-y) \ > - $(note_file_option) -o $@ > - $(NM) -pa --format=sysv $@ \ > + $(note_file_option) -o [email protected] > + $(NM) -pa --format=sysv [email protected] \
Why is this needed in this shape? Can't you use $(TARGET)-syms.efi here right away, ... > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv > --sort \ > > [email protected] > ifeq ($(CONFIG_DEBUG_INFO),y) > - $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O > elf64-x86-64 $@ [email protected] > + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) \ > + -O elf64-x86-64 [email protected] [email protected] > + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))mv -f \ > + [email protected] $(TARGET)-syms.efi ... avoiding the need for this mv and ... > + $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(STRIP) \ > + $(TARGET)-syms.efi -o [email protected] ... double use of [email protected]? > endif > - rm -f $(dot-target).[0-9]* $(@D)/..$(@F).[0-9]* > ifeq ($(CONFIG_XEN_IBT),y) > - $(SHELL) $(srctree)/tools/check-endbr.sh $@ > + $(SHELL) $(srctree)/tools/check-endbr.sh [email protected] > endif > + mv -f [email protected] $@ > + rm -f $(dot-target).[0-9]* $(@D)/..$(@F).[0-9]* At least part of the rearrangement here also looks unrelated, and isn't mentioned at all in the description. Jan
