Hi Mykola,
On 07/11/2025 08:27, Mykola Kvach wrote:
+void __init llc_coloring_init(void)
+{
+ unsigned int way_size;
+
+ llc_coloring_enabled = (opt_llc_coloring >= 1);
+ if ( (opt_llc_coloring != 0) && llc_size && llc_nr_ways )
+ {
+ llc_coloring_enabled = true;
+ way_size = llc_size / llc_nr_ways;
+ }
+ else if ( !llc_coloring_enabled )
+ return;
+ else
+ {
+ way_size = get_llc_way_size();
+ if ( !way_size )
+ panic("LLC probing failed and 'llc-size' or 'llc-nr-ways'
missing\n");
As far as I can see, this error means that we did not detect a suitable
LLC/unified cache.
Maybe it would be better to make that explicit in the panic message.
I am rather confused why there are reviews on the series that was merged
nearly a year ago. If you have comments that needs to be addressed, then
it would be best to either send a new series or start a new thread (if
there are bugs which needs discussion).
Cheers,
--
Julien Grall
