On 12/11/2025 08:47, Luca Fancellu wrote:
> Hi Dmytro,
>
>> On 12 Nov 2025, at 07:08, Dmytro Prokopchuk1 <[email protected]>
>> wrote:
>>
>> Remove the redundant local 'DTB_MAGIC' definition and replace its usage
>> with the canonical 'FDT_MAGIC' from 'libfdt'.
>>
>> Fixes: 66edeb2e3972 (arm: copy DTB appended to zImage)
NIT: Fixes is for bugs. Redundant macro is not a bug I believe.
~Michal
>> Signed-off-by: Dmytro Prokopchuk <[email protected]>
>> ---
>
> Looks good to me!
>
> Reviewed-by: Luca Fancellu <[email protected]>
>
> while there I noticed we have DTB_MAGIC that seems to be not used in the
> toolstack
> xen/tools/libs/guest/xg_dom_armzimageloader.c.
>
> I don’t think that should be addressed in this patch, I just wanted to raise
> awareness.
>
> Cheers,
> Luca
>
>
