On 13.11.2025 04:16, Penny Zheng wrote: > Memory access and ALTP2M are two seperate features, while both depending on > helper xenmem_access_to_p2m_access(). So it betters lives in common p2m.c, > other than mem_access.c which will be compiled out when VM_EVENT=n && > ALTP2M=y.
Yet when both are off, the function becomes unreachable? I.e. doesn't there need to be #ifdef around it, to please Misra? > Coding style has been corrected at the same time. That is, blank lines were inserted and nothing else, afaics. Could have been said explicitly. > Signed-off-by: Penny Zheng <[email protected]> > --- > v3 -> v4: > - new commit > --- > xen/arch/x86/mm/mem_access.c | 36 ---------------------------------- > xen/arch/x86/mm/p2m.c | 38 ++++++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+), 36 deletions(-) Imo with this movement, the declaration wants to move out of mem_access.h as well. Jan
