On Thu Nov 13, 2025 at 12:50 PM CET, Jan Beulich wrote: > On 12.11.2025 16:22, Alejandro Vallejo wrote: >> They are unnecessary. The only two cases with link-time failures are >> fallback else branches that can just as well be adjusted with explicit >> IS_ENABLED(CONFIG_PV). HVM has no equivalent stubs and there's no reason >> to keep the asymmetry. >> >> No functional change. >> >> Signed-off-by: Alejandro Vallejo <[email protected]> >> --- >> I'd rather remove the "rc = -EOPNOTSUPP" branch altogether, or replace >> it with ASSERT_UNREACHABLE(), but I kept it here to preserve prior behaviour. >> >> Thoughts? > > I think using ASSERT_UNREACHABLE() there would be better, in particular bring > things in line with the {hvm,pv}_domain_initialise() call site. Preferably > that way (happy to adjust while committing): > Reviewed-by: Jan Beulich <[email protected]> > > Jan
Sounds good to me. Though arguablt the commit message might need to change too to remove the last line about not being a functional change. While not externally visible, it is a real change. Cheers, Alejandro
