On 13.11.2025 14:01, Andrew Cooper wrote:
> This is a partial backport of commit 63ebd0e9649e ("releases: use newer
> compression methods for tarballs"), but keeping gz as the only compression
> method.
>
> In addition to efficiency, this causes the tarball to use root/root ownership,
> rather than leak whomever produced the tarball.
I don't understand this part. Isn't the ownership whatever "git archive"
reports?
I have to admit though ...
> --- a/tools/misc/mktarball
> +++ b/tools/misc/mktarball
> @@ -5,14 +5,6 @@
> # Takes 2 arguments, the path to the dist directory and the version
> set -ex
>
> -function git_archive_into {
> - mkdir -p "$2"
> -
> - git --git-dir="$1"/.git \
> - archive --format=tar HEAD | \
> - tar Cxf "$2" -
... that I'm unaware of what the C here does. It can't be the same as -C, and
the
--help output of the GNU tar that I checked doesn't mention anything else at
all.
Jan
