On 13.11.25 17:49, Jan Beulich wrote:
On 11.11.2025 17:19, Juergen Gross wrote:--- a/Config.mk +++ b/Config.mk @@ -159,6 +159,20 @@ define move-if-changed if ! cmp -s $(1) $(2); then mv -f $(1) $(2); else rm -f $(1); fi endef+PATH_FILES := Paths+INC_FILES := $(foreach f, $(PATH_FILES), $(XEN_ROOT)/config/$(f).mk) + +include $(INC_FILES) + +BUILD_MAKE_VARS := $(foreach f, $(PATH_FILES), $(shell awk '$$2 == ":=" { print $$1; }' $(XEN_ROOT)/config/$(f).mk.in)) + +define apply-build-vars + sed $(foreach v, $(BUILD_MAKE_VARS), -e 's#@$(v)@#$($(v))#g') <$< >$@ +endef + +%:: %.src + $(apply-build-vars)I'm not convinced of having this here, rather than in less central places (say under tools/ and docs/). I'm also not sure I really understand why it needs to be .src - can't we stick to .in, enumerating the specific files that want generating this way (thus avoiding accidental attempts to re-generate files which need generating a different way)?
With enumerating the files to generate we could probably stick to *.in. I'm fine with moving the rule to the tools and docs makefiles, but I'd like to keep the apply-build-vars definition here in order to avoid duplicating it.
Also - why the double colon here?
I've followed the advice in the make reference for "match-anything pattern rules". With enumerating the files to generate it should be possible to avoid the double colon. Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
