Vladimir Sementsov-Ogievskiy <[email protected]> writes: > On 19.11.25 16:08, Markus Armbruster wrote: >> bbram_bdrv_error() interpolates a "detail" string into a template with >> error_setg_errno(), then reports the result with error_report(). >> Produces error messages with an unwanted '.': >> >> BLK-NAME: BBRAM backstore DETAIL failed.: STERROR >> >> Replace both calls of bbram_bdrv_error() by straightforward >> error_report(), and drop the function. This is less code, easier to >> read, and the error message is more greppable. >> >> Also delete the unwanted '.'. > > Also, using "errp" name for local "Error *" (one star) variable is a bit > misleading.
True. I don't mention it, because I delete the variable. My search for misleading uses of @errp led me here. >> Signed-off-by: Markus Armbruster <[email protected]> > > Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> Thanks!
