On Mon, Nov 24, 2025 at 8:19 AM Andrew Cooper <[email protected]> wrote: > > On 24/11/2025 1:17 pm, Saman Dehghan wrote: > > diff --git a/xen/Kconfig b/xen/Kconfig > > index a5e5af3b76..8f2cc111cd 100644 > > --- a/xen/Kconfig > > +++ b/xen/Kconfig > > @@ -51,9 +51,14 @@ config CC_HAS_ASM_GOTO_OUTPUT > > depends on !GCC_ASM_GOTO_OUTPUT_BROKEN > > depends on $(success,echo 'int foo(int x) { asm goto ("": "=r"(x) ::: > > bar); return x; bar: return 0; }' | $(CC) -x c - -c -o /dev/null) > > > > -# Compiler supports -fcondition-coverage aka MC/DC > > +# Compiler supports Modified Condition/Decision Coverage (MC/DC). > > Ah sorry, I only meant for this line. Enough for someone to usefully > google. > > Otherwise, Reviewed-by: Andrew Cooper <[email protected]> > > I can trim this down on commit if you're happy. > > ~Andrew
I’m happy with it, thanks a lot Andrew for suggesting to trim that line. ~Saman > > > +# MC/DC is a rigorous code coverage metric that requires every condition > > +# within a decision (boolean expression) to be shown to independently > > +# influence the decision's final outcome. > > +# > > +# Minimum toolchain baseline: GCC >= 14, or Clang >= 18. > > config CC_HAS_MCDC > > - def_bool $(cc-option,-fcondition-coverage) > > + def_bool $(cc-option,-fcondition-coverage) || > > $(cc-option,-fprofile-instr-generate -fcoverage-mapping -fcoverage-mcdc) > > > > # Set code alignment. > > # > >
