On 24.11.2025 15:35, Jason Andryuk wrote:
> On 2025-11-24 07:25, Jan Beulich wrote:
>> --- a/xen/arch/x86/acpi/cpufreq/hwp.c
>> +++ b/xen/arch/x86/acpi/cpufreq/hwp.c
>
>> @@ -226,7 +214,8 @@ static int cf_check hwp_cpufreq_verify(s
>> {
>> struct hwp_drv_data *data = per_cpu(hwp_drv_data, policy->cpu);
>>
>> - if ( !feature_hwp_activity_window && data->activity_window )
>> + if ( !cpu_has_hwp_activity_window &&
>> + data->activity_window )
>
> This ...
>> {
>> hwp_verbose("HWP activity window not supported\n");
>>
>
>> @@ -537,7 +526,8 @@ int get_hwp_para(unsigned int cpu,
>> return -ENODATA;
>>
>> cppc_para->features =
>> - (feature_hwp_activity_window ? XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW : 0);
>> + (cpu_has_hwp_activity_window
>> + ? XEN_SYSCTL_CPPC_FEAT_ACT_WINDOW : 0);
>
> ...and this can still be on one line.
Oh, yes, the lines now became shorter again.
> Preferably with that fixed:
>
> Reviewed-by: Jason Andryuk <[email protected]>
Thanks.
Jan
