On 21.11.2025 11:57, Penny Zheng wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -29,7 +29,7 @@ config X86 > select HAS_PCI_MSI > select HAS_PIRQ > select HAS_SCHED_GRANULARITY > - imply HAS_SOFT_RESET > + select HAS_SOFT_RESET if MGMT_HYPERCALLS
Why would you undo an "imply", when really we should use it more? One of its purposes is so that you can add "depends on MGMT_HYPERCALLS" there, and it then won't be auto-enabled if that dependency isn't fulfilled. > --- a/xen/arch/x86/include/asm/paging.h > +++ b/xen/arch/x86/include/asm/paging.h > @@ -55,7 +55,7 @@ > #define PG_translate 0 > #define PG_external 0 > #endif > -#if defined(CONFIG_PAGING) && !defined(CONFIG_PV_SHIM_EXCLUSIVE) > +#if defined(CONFIG_PAGING) && !defined(CONFIG_PV_SHIM_EXCLUSIVE) && > defined(CONFIG_MGMT_HYPERCALLS) This line is too long now. > @@ -299,7 +299,9 @@ hypfs_op do do do > do do > #endif > mca do do - - - > #if defined(CONFIG_X86) && defined(CONFIG_PAGING) && > !defined(CONFIG_PV_SHIM_EXCLUSIVE) > +#ifdef CONFIG_MGMT_HYPERCALLS Why not combine with the existing #if? Jan
