On 05.12.2025 13:40, Andrew Cooper wrote: > On 05/12/2025 12:01 pm, Andrew Cooper wrote: >> On 24/11/2025 3:01 pm, Jan Beulich wrote: >>> --- a/xen/arch/x86/include/asm/bug.h >>> +++ b/xen/arch/x86/include/asm/bug.h >>> @@ -21,7 +21,7 @@ >>> >>> #ifndef __ASSEMBLY__ >>> >>> -#define BUG_INSTR "ud2" >>> +#define BUG_INSTR ".byte 0xd6" /* UDB */ >>> #define BUG_ASM_CONST "c" >>> >>> #else /* !__ASSEMBLY__ */ >>> @@ -37,7 +37,7 @@ >>> .error "Invalid BUGFRAME index" >>> .endif >>> >>> - .L\@ud: ud2a >>> + .L\@ud: .byte 0xd6 /* UDB */ > > P.S. Presumably binutils is going to learn a udb mnemonic at some > point? Can we include a version number in the comment? > > I'm trying to organise such comments everywhere so it's less effort to > figure out when we can drop it in the future.
For them to be useful, wouldn't we need to settle on some canonical form first? Else how would one locate them (other than by coming across them by chance)? Jan
