Hi, Thanks for the review. On Fri, Dec 5, 2025 at 4:57 PM Andrew Cooper <[email protected]> wrote: > > On 05/12/2025 2:54 pm, Mykola Kvach wrote: > > Hi, > > > > On Fri, Dec 5, 2025 at 3:57 PM Marek Marczykowski-Górecki > > <[email protected]> wrote: > >> On Fri, Dec 05, 2025 at 03:13:32PM +0200, Mykola Kvach wrote: > >>> From: Mykola Kvach <[email protected]> > >>> > >>> Using PKG_CHECK_VAR() to obtain SYSTEMD_SLEEP_DIR reintroduced a > >>> build-time > >>> dependency on systemd-devel. This breaks --enable-systemd builds that only > >>> need the initscripts. > >>> > >>> Use the same defaulting scheme as other systemd paths: if > >>> SYSTEMD_SLEEP_DIR > >>> isn't provided, set it to "$(prefix)/lib/systemd/system-sleep/". > >>> > >>> Fixes: e54a6cd6a1f3 ("systemd: Add hooks to stop/start xen-watchdog on > >>> suspend/resume") > >>> Reported-by: Marek Marczykowski-Górecki <[email protected]> > >>> Signed-off-by: Mykola Kvach <[email protected]> > >>> --- > >>> Build in which the regression was detected: > >>> https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/10959608099 > >> Requires re-running autoconf, otherwise still fails: > > Thanks for the note. I had assumed the Autoconf-generated files were > > refreshed > > during release or at merge time, since this updates generated artifacts. If > > the > > expectation is that contributors regenerate and include them with the patch, > > I will add the updated Autoconf outputs in the next revision of this series. > > We regenerate on commit, but that still needs a reminder to remember to > do so.
Got it, thanks for the clarification. > > > > >> https://gitlab.com/xen-project/people/marmarek/xen/-/jobs/12336879267 > >> > >> With autoconf: > >> https://gitlab.com/xen-project/people/marmarek/xen/-/pipelines/2198372475 > >> > >> It's better now, so: > >> Reviewed-by: Marek Marczykowski-Górecki <[email protected]> > > Acked-by: Andrew Cooper <[email protected]> > > Thanks for the quick turnaround. I'll queue this shortly. Best regards, Mykola
