On 18.12.2025 19:56, Stewart Hildebrand wrote:
> On 12/18/25 11:14, Jan Beulich wrote:
>> On 18.12.2025 16:37, Stewart Hildebrand wrote:
>>> On 12/18/25 02:56, Jan Beulich wrote:
>>>> The DomU part of the function worries me as well. Rather than making it
>>>> "read 0, write ignore" for just the first 32 bits, shouldn't we make it so
>>>> for the entire extended config space, and shouldn't we also make it "read
>>>> all ones, write ignore" when there is no extended config space in the
>>>> first place (then in particular also for the first 32 bits)?
>>>
>>> Hm, yes, perhaps. If we simply omit the call to vpci_add_register(), it
>>> should
>>> default to the "read all ones, write ignore" behavior.
>>
>> But it doesn't right now, unless I'm mistaken?
>
> For !is_hardware_domain(d), any access that isn't explicitly handled with
> vpci_add_register{,*}() will default to "read all 1s, write ignore". See
> vpci_{read,write}_hw().
Oh, indeed - I keep forgetting that "read hardware" as indicated by the name
doesn't really mean "read hardware" in all cases. (IOW I find this confusing.)
Jan
