On 05.02.2026 00:30, Stefano Stabellini wrote: > On Wed, 4 Feb 2026, Jan Beulich wrote: >> 2) As all of this is for dom0less only (for now at least), did you consider >> to make all of these changes dependent upon a new Kconfig option, so to >> avoid impacting other environments in case issues remain when this has >> gone in? > > Effectively it is already the case because: > > #define max_console_rx (max_init_domid + 1) > > I could easily add an #ifdef around is_focus_domain() so that in case > CONFIG_DOM0LESS_BOOT is disabled it defaults to is_hardware_domain() but > that wouldn't really help because thanks to the definition of > max_console_rx, effectively it works the same way when > CONFIG_DOM0LESS_BOOT is disabled. > > I think what you are asking would be more about the locking changes in > guest_console_write, but for those I cannot really use #ifdef to retain > the current position of the locks. The resulting code would not be good.
Yes, the request was (primarily) about the locking changes (additions!), as these can affect non-dom0less as well. I may try to make suggestions when looking at the next version. Jan
