On 05.02.2026 18:27, Teddy Astie wrote: > Many machines fail to boot if this option is disabled, as > there are no known drawback toggling this option, enable it > by default.
"no known drawback" ignores why it wasn't enabled originally. Imo this wants at least mentioning, if not discussing. > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -363,13 +363,14 @@ config KEXEC > > config EFI_SET_VIRTUAL_ADDRESS_MAP > bool "EFI: call SetVirtualAddressMap()" if EXPERT > + default y > help > Call EFI SetVirtualAddressMap() runtime service to setup memory map for > further runtime services. According to UEFI spec, it isn't strictly > necessary, but many UEFI implementations misbehave when this call is > missing. > > - If unsure, say N. > + If unsure, say Y. When this was added, it was actually hacked in with the aim of minimal intrusiveness. When we now default it to on, I wonder if other changes shouldn't be made (maybe not right in this patch, but perhaps in a single series). For example, identity mapping (with its implied restrictions) ought to be possible to do away with when the option is enabled. Whether the separate EFI page tables would still be needed also is questionable. I further wonder whether the EXPERT dependency of the prompt wouldn't better be dropped when flipping the default. Jan
