Sorry for putting you in the To field, I'll use Cc in the future. I agree that the commit message is a little short, and I will iterate on that. Furthermore, I agree that gcc compatibility would allow to parse this statement. However, the given sequence is not unique, and the gcc documentation states that the semicolon is mandatory.
https://gcc.gnu.org/onlinedocs/gcc/Label-Attributes.html I'll add more details to the commit message. Best, Norbert On 07/31/2018 09:48 AM, Jan Beulich wrote: >>>> On 31.07.18 at 09:18, <[email protected]> wrote: >> To be able to compile Xen with gotocc, the label statement has to be >> followed by a semicolon. > > Assuming that gotocc aims to be gcc compatible, this looks like a > shortcoming there. As the workaround is simple enough, I'm fine > with the change, but the description should then say so. Or > otherwise it should as well clarify the situation. > > Furthermore - please follow patch submission rules: Patches get > sent _To_ the list, with _all_ maintainers _Cc_-ed. > > Jan > > > Amazon Development Center Germany GmbH Berlin - Dresden - Aachen main office: Krausenstr. 38, 10117 Berlin Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger Ust-ID: DE289237879 Eingetragen am Amtsgericht Charlottenburg HRB 149173 B _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
