On 16/05/2023 8:41 am, Jan Beulich wrote:
> Emulation related functions are involved in HVM handling only
I think this wants clarifying a little. *These* emulation functions are
only used by HVM.
pv/ro-page-fault.c does have emulation for PV guests, but uses
paging_{write,cmpxchg}_guest_entry() to enter into the shadow code.
> , and in
> some cases they even invoke such checks after having already done things
> which are valid for HVM domains only. OOS active also implies HVM. In
> sh_remove_all_mappings() one of the two checks is redundant with an
> earlier paging_mode_external() one (the other, however, needs to stay).
>
> Signed-off-by: Jan Beulich <[email protected]>
Preferably with the commit message tweaked, Acked-by: Andrew Cooper
<[email protected]>
