On Wed, Aug 01, 2018 at 10:26:06AM -0400, Jason Andryuk wrote:
> On Mon, Jul 30, 2018 at 11:56 PM, Marek Marczykowski-Górecki
> <marma...@invisiblethingslab.com> wrote:
> > From: Eric Shelton <eshel...@pobox.com>
> >
> > This will build a Linux-based stubdomain with QEMU upstream.
> >
> > Signed-off-by: Eric Shelton <eshel...@pobox.com>
> >
> > Simon:
> > * use initramfs instead of disk with rootfs
> > * don't initialize qmp (unused in Qubes)
> > * Make libxl_domain_need_memory consistent with actual stubdoma build
> > code (bugfix relevant also for non-linux case)
> > * Make stubdomain memory size configurable
> > Signed-off-by: Simon Gaiser <si...@invisiblethingslab.com>
> >
> > Marek:
> > * Make kernel and ramdisk paths configurable.
> > Signed-off-by: Marek Marczykowski-Górecki <marma...@invisiblethingslab.com>
> > ---
>
> <snip>
>
> > @@ -1983,10 +1997,8 @@ void libxl__spawn_stub_dm(libxl__egc *egc,
> > libxl__stub_dm_spawn_state *sdss)
> > dm_config->num_vkbs = 1;
> > }
> >
> > - stubdom_state->pv_kernel.path
> > - = libxl__abs_path(gc, "ioemu-stubdom.gz",
> > libxl__xenfirmwaredir_path());
> > - stubdom_state->pv_cmdline = GCSPRINTF(" -d %d", guest_domid);
>
> This dropped line isn't restored anywhere else, afaics. Does this
> break mini-os stubdoms?No, mini-os gets cmdline from xenstore anyway. And libxl__build_device_model_args_old do add -d domid there. -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing?
signature.asc
Description: PGP signature
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
