On Wed, Apr 08, 2026 at 02:07:23PM +0200, Jan Beulich wrote: > This core backing function is uniform; what varies across architectures > are the attributes passed and hence the wrappers around it. Yet of course > extra checking or special handling may be needed per arch, so introduce a > suitable hook. > > Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Roger Pau Monné <[email protected]> Just looked at the common and x86 bits, both LGTM. > --- > Declarations (or inline counterparts) aren't being moved around, to avoid > the need to touch source files using the functions. Quite possibly they > want to consistently go into xen/io.h and asm/io.h. > > Of course ioremap.c could also go into lib/. Maybe I'm missing the point, but what's the benefit for it to go into lib/? Is there any realistic scenario where we might have a functional hypervisor build that doesn't require ioremap? Thanks, Roger.
