On Thu, 9 Apr 2026, Luca Fancellu wrote:
> Hi Michal,
> 
> > On 9 Apr 2026, at 12:39, Michal Orzel <[email protected]> wrote:
> > 
> > iomem_deny_access() wraps rangeset_remove_range() which takes inclusive
> > endpoints.  All call sites in the GIC and ACPI code pass 'mfn + nr' (or
> > 'mfn + 1' for single-page regions) as the end parameter, which causes
> > one extra page beyond each region to be denied.
> > 
> > For single-page regions, use 'mfn' as the end (denying exactly one page).
> > For all multi-page regions, use 'mfn + nr - 1'.
> > 
> > This matches the correct pattern used elsewhere, e.g. in device.c.
> > 
> > Fixes: 8300b3377e ("arm/gic: Add a new callback to deny Dom0 access to GIC 
> > regions")
> > Fixes: 66158be465 ("ARM: ITS: Deny hardware domain access to ITS")
> > Fixes: 97e9875646 ("arm/acpi: Permit MMIO access of Xen unused devices for 
> > Dom0")
> > Signed-off-by: Michal Orzel <[email protected]>
> > ---
> > 
> 
> This looks ok to me.
> 
> Reviewed-by: Luca Fancellu <[email protected]>

Reviewed-by: Stefano Stabellini <[email protected]>

Reply via email to