On 01.09.2026 09:14, Orzel, Michal wrote: > On 01-Sep-26 08:54, Jan Beulich wrote: >> On 31.08.2026 17:48, Orzel, Michal wrote: >>> On 27-Aug-26 17:18, Oleksii Kurochko wrote: >>>> --- a/xen/drivers/char/console.c >>>> +++ b/xen/drivers/char/console.c >>>> @@ -31,6 +31,7 @@ >>>> #include <xen/warning.h> >>>> #include <xen/pv_console.h> >>>> #include <asm/setup.h> >>> NIT: This can be dropped - I don't see anything relying on it in this file. >> >> Did you mean to ask for asm/setup.h to be dropped here, when that's entirely >> unrelated? If not, the other change you are asking for could surely be done > Why are you saying that this is unrelated? Before this change `max_init_domid` > declaration was in asm/setup.h and this was the reason for this header to be > included here. With this patch, the declaration is moved to dom0less.h and > therefore asm/setup.h is no longer needed to be included. I consider it very > much related unless I'm missing something.
Hmm, fair point. Yet I'm then still somewhat concerned that asm/setup.h may have supplied something else. IOW I'd thus rather leave it to Oleksii to make the adjustment in v9, once suitably verified to be correct to do. Jan
