Doing so (at the return statement), besides being a bad idea anyway, is a violation of Misra rule 11.8.
Make "xcap" have an initializer while adjusting the code anyway. No functional change intended. Signed-off-by: Jan Beulich <[email protected]> --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -384,16 +384,15 @@ static bool __init dbc_init_xhc(struct d */ static struct dbc_reg __iomem *xhci_find_dbc(struct dbc *dbc) { - const uint32_t __iomem *xcap; uint32_t xcap_val; uint32_t next; uint32_t id = 0; - const void __iomem *mmio = dbc->xhc_mmio; + void __iomem *mmio = dbc->xhc_mmio; const uint32_t __iomem *hccp1 = mmio + 0x10; + uint32_t __iomem *xcap = mmio; const uint32_t DBC_ID = 0xA; int ttl = 48; - xcap = mmio; /* * This is initially an offset to the first capability. All the offsets * (both in HCCP1 and then next capability pointer) are dword-based.
