On 02.09.2026 13:43, Andrew Cooper wrote: > All this does is obfuscate the usage sites.
I don't mind these changes, yet I'd like to express that as so often there are multiple ways of looking at things. The benefit of the macros was that the use sites were textually shorter, and hence easier to process (assuming you know what ADDR stands for). > --- a/xen/arch/x86/include/asm/bitops.h > +++ b/xen/arch/x86/include/asm/bitops.h > @@ -9,16 +9,6 @@ > #include <asm/asm_defns.h> > #include <asm/cpufeatureset.h> > > -/* > - * We specify the memory operand as both input and output because the memory > - * operand is both read from and written to. Since the operand is in fact a > - * word array, we also specify "memory" in the clobbers list to indicate that > - * words other than the one directly addressed by the memory operand may be > - * modified. > - */ Might we not better keep this justification for the seemingly odd memory clobbers? (The first sentence, otoh, I agree can be dropped.) Jan
