Re: [PATCH v2 10/39] xen/riscv: build the target hart index via aplic_hart_field()

[Oleksii Kurochko]

On 9/4/26 10:26 AM, Baptiste Le Duc wrote:
On Thu, 27 Aug 2026 17:20:54 +0200, Oleksii Kurochko 
<oleksii.kuroc...@gmail.com> wrote:
aplic_set_irq_affinity() open-coded the packing of the group and hart
indices into the target register, and got two things wrong along the
way:

  - imsic_config.msi[] is indexed by logical CPU id, but the index was
    run through cpuid_to_hartid() first. On any platform where the two
    spaces differ this picks another CPU's interrupt file, or reads past
    the array;

[...]

Reviewed-by: Baptiste Le Duc <baptiste.le-...@vates.tech>


Thanks.

Considering your suggestion regarding renaming of the function 
aplic_hart_field() in the prev. patches. I will also do here:

@ -344 +344 @@ static void cf_check aplic_set_irq_affinity(struct 
irq_desc *desc, const cpumask
-    value = MASK_INSR(aplic_hart_field(cpu), APLIC_TARGET_HART_IDX) |
+    value = MASK_INSR(aplic_hart_index(cpu), APLIC_TARGET_HART_IDX) |

+

Update the functions name in the commit message.

~ Oleksii