On 10.09.2026 09:44, Roger Pau Monné wrote: > On Fri, Aug 28, 2026 at 09:06:20AM +0200, Jan Beulich wrote: >> The 16-bit range of "port" is fully handled by the switch(). Therefore the >> default: case is reported unreachable by Eclair. Insert BUILD_ERROR() to >> annotate this for Eclair. >> >> No functional change. >> >> Signed-off-by: Jan Beulich <[email protected]> > > Acked-by: Roger Pau Monné <[email protected]>
Thanks. > That however is a bit weird IMO, as we have usually said we would > prefer not to use fixed width types in general, and hence one might > argue that port should be unsigned int. Then the BUILD_ERROR() might > trigger? Yes, such a type change would need accompanying by removal of that BUILD_ERROR(). The default: case then also wouldn't be deemed unreachable anymore (even though in practice it still would be). Jan
