On Mon, Aug 20, 2018 at 1:38 AM, Wei Liu <wei.l...@citrix.com> wrote: > On Sat, Aug 18, 2018 at 09:22:05PM -0500, Doug Goldstein wrote: >> The tboot targets are woefully out of date. These should really be >> retired because setting up tboot is more complex than the build process >> for it. >> >> Signed-off-by: Doug Goldstein <car...@cardoe.com> > > Acked-by: Wei Liu <wei.l...@citrix.com>
Code reviewed and standard (non-tboot related) build tested with the patch applied: looks good. No references to any of the following remain in the tree afterwards: * TBOOT_TARFILE * TBOOT_BASE_URL * build-tboot, install-tboot, dist-tboot, clean-tboot, distclean-tboot * download_tboot The README section about tboot, just above the chunk removed, contains a stale URL for the tboot hg repository, which has apparently now moved to: http://hg.code.sf.net/p/tboot/code I don't use uninstall (ever) but since Doug's patch touches it, I just tested it with this applied. Uninstall failed, but it's not a fault of this patch: | make[6]: Entering directory './git/tools/tests/x86_emulator' | make[6]: *** No rule to make target 'uninstall'. Stop. | make[6]: Leaving directory './git/tools/tests/x86_emulator' | | make[6]: *** No rule to make target 'uninstall'. Stop. | make[6]: Leaving directory '/./git/tools/tests/x86_emulator' | ./git/tools/tests/../../tools/Rules.mk:249: recipe for target 'subdir-uninstall-x86_emulator' failed | make[5]: *** [subdir-uninstall-x86_emulator] Error 2 | make[5]: Leaving directory './git/tools/tests' | | ./git/tools/tests/../../tools/Rules.mk:249: recipe for target 'subdir-uninstall-x86_emulator' failed so I've just posted a patch that fixes this and another defect in the Linux hotplug uninstall logic to make it actually remove what it installed. Reviewed-by: Christopher Clark <christopher.cla...@baesystems.com> Christopher _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
