On 04/09/18 18:01, Anthony PERARD wrote: > On Wed, Aug 29, 2018 at 02:22:05PM +0200, Olaf Hering wrote: >> On Mon, Aug 27, Olaf Hering wrote: >> >>> Since about two weeks, no released qemu can be built against >>> xen.git#staging. The error looks like that: >>> qemu-20180825T130857.235c82acca/include/hw/xen/xen_common.h:677:5: error: >>> too many arguments to function 'xc_domain_create' >>> It looks like staging lacks proper compat wrappers for released qemu >>> versions. >> Passing --disable-xen-pv-domain-build instead of >> --enable-xen-pv-domain-build to configure fixes/hides the build error. >> >> What is "xen-pv-domain-build" supposed to do? > It suppose to let QEMU create a Xen domain all by itself, without using > any toolstack. Nickname: xenner. > > But that code probably doesn't work anymore.
Having a quick look over the code, its been completely broken since Xen 4.9 (it never called gnttab_set_limits()), and appears to only function for PV guests (by use of the xc_linux_build() call), and clearly noone has noticed/cared. If I were you, I'd purge it completely from qemu. You don't want to be playing "keep up with all the changes going into xc_domain_create()", given how tightly coupled it is to other low level libxc functionality. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
