> -----Original Message----- > From: zhong jiang [mailto:zhongji...@huawei.com] > Sent: 08 September 2018 14:35 > To: da...@davemloft.net; Paul Durrant <paul.durr...@citrix.com>; Wei Liu > <wei.l...@citrix.com> > Cc: xen-devel@lists.xenproject.org; net...@vger.kernel.org > Subject: [PATCH] net: xenbus: remove redundant condition check before > debugfs_remove_recursive > > debugfs_remove_recursive has taken the IS_ERR_OR_NULL into account. > Just > remove the unnecessary condition check. > > Signed-off-by: zhong jiang <zhongji...@huawei.com>
Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > --- > drivers/net/xen-netback/xenbus.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/xen-netback/xenbus.c b/drivers/net/xen- > netback/xenbus.c > index cd51492..fe1d522 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -254,8 +254,7 @@ static void xenvif_debugfs_delif(struct xenvif *vif) > if (IS_ERR_OR_NULL(xen_netback_dbg_root)) > return; > > - if (!IS_ERR_OR_NULL(vif->xenvif_dbg_root)) > - debugfs_remove_recursive(vif->xenvif_dbg_root); > + debugfs_remove_recursive(vif->xenvif_dbg_root); > vif->xenvif_dbg_root = NULL; > } > #endif /* CONFIG_DEBUG_FS */ > -- > 1.7.12.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
