On Wed, Sep 26, 2018 at 02:44:07PM +0100, Paul Durrant wrote: > ...and change the name to amd_iommu_get_address_from_pte() since the > address read is not necessarily the address of a next level page table. > (If the 'next level' field is not 1 - 6 then the address is a page > address). > > The constants in use prior to this patch relate to device table entries > rather than page table entries. Although they do have the same value, it > makes the code confusing to read. > > This patch also changes the PDE/PTE pointer argument to void *, and > removes any u32/uint32_t casts in the call sites. Unnecessary casts > surrounding call sites are also removed. > > No functional change. > > NOTE: The patch also adds emacs boilerplate to iommu_map.c > > Signed-off-by: Paul Durrant <[email protected]>
Not thrilled about adding the emacs part but it's allowed in the coding style guide so. Reviewd-by: Brian Woods <[email protected]> -- Brian Woods _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
