On Thu, Sep 27, 2018 at 01:46:01PM +0100, Paul Durrant wrote: > The levels are absolute numbers such that IOMMU_PAGING_MODE_LEVEL_X > evaluates to X (for the valid range of 0 - 7) so simply use numbers in > the code. > > No functional change. > > NOTE: This patch also adds emacs boilerplate to amd-iommu-defs.h > > Signed-off-by: Paul Durrant <paul.durr...@citrix.com>
Is there a strong reason to get rid of these? Some of examples below create seemingly magic numbers in the code. While if you're familiar with the functions this isn't a big deal, otherwise you have to dig further to tell. > + pte = table + pfn_to_pde_idx(gfn, 1); > + need_flush = set_iommu_pde_present(pde, next_mfn, 0, iw, ir); If there's a general consensus that getting rid of these is better, I don't mind and will agree to it. -- Brian Woods _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
