On 10/16/18 6:56 AM, Julien Grall wrote:
> Hi,
>
> On 10/16/2018 09:38 AM, Stefano Stabellini wrote:
>> xen_create_contiguous_region has now only an implementation if
>> CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
>> we do have an implementation of xen_create_contiguous_region which is
>> required for swiotlb-xen to work correctly (although it just sets
>> *dma_handle). >
>> This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
>
> Linux is using the tag "Fixes: sha1 ("commit title")" so it can be
> picked up for backporting.


SoB would also be good to have ;-)

Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com>

>
> Acked-by: Julien Grall <julien.gr...@arm.com>
>
> Cheers,
>>
>> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>> index fd18c97..939a962 100644
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
>>     extern unsigned long *xen_contiguous_bitmap;
>>   -#ifdef CONFIG_XEN_PV
>> +#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
>>   int xen_create_contiguous_region(phys_addr_t pstart, unsigned int
>> order,
>>                   unsigned int address_bits,
>>                   dma_addr_t *dma_handle);
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xenproject.org
>> https://lists.xenproject.org/mailman/listinfo/xen-devel
>>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Reply via email to