On 19/10/2018 13:54, Daniel Kiper wrote: > On Tue, Oct 09, 2018 at 01:03:06PM +0200, Juergen Gross wrote: >> include/grub/offsets.h needs some defines for Xen PVH mode. >> >> Add them. While at it line up the values in the surrounding lines to >> start at the same column. >> >> Signed-off-by: Juergen Gross <jgr...@suse.com> >> --- >> include/grub/offsets.h | 21 ++++++++++++--------- >> 1 file changed, 12 insertions(+), 9 deletions(-) >> >> diff --git a/include/grub/offsets.h b/include/grub/offsets.h >> index 330e4c707..b16353163 100644 >> --- a/include/grub/offsets.h >> +++ b/include/grub/offsets.h >> @@ -36,9 +36,10 @@ >> #define GRUB_DECOMPRESSOR_I386_PC_MAX_DECOMPRESSOR_SIZE (0x9000-0x8200) >> >> /* The segment where the kernel is loaded. */ >> -#define GRUB_BOOT_I386_PC_KERNEL_SEG 0x800 >> +#define GRUB_BOOT_I386_PC_KERNEL_SEG 0x800 >> >> -#define GRUB_KERNEL_I386_PC_LINK_ADDR 0x9000 >> +#define GRUB_KERNEL_I386_PC_LINK_ADDR 0x9000 >> +#define GRUB_KERNEL_I386_XENPVH_LINK_ADDR 0x100000 > > s/XENPVH/XEN_PVH/ In general I prefer XEN_PVH instead of XENPVH. > So, please update them all where possible. Not only in this patch.
Does this apply to path names as well (e.g. include/grub/i386/xenpvh/) ? Or do you mean macros/symbols only? BTW: if yes, this would affect the visible platform name, too. Juergen _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel