Hi Ian,
On 10/30/18 3:20 PM, Ian Jackson wrote:
Stefano Stabellini writes ("[PATCH v8 2/8] libxl: introduce a new structure to
represent static shared memory regions"):
From: Zhongze Liu <blacksk...@gmail.com>
Author: Zhongze Liu <blacksk...@gmail.com>
Add a new structure to the IDL family to represent static shared memory regions
as proposed in the proposal "Allow setting up shared memory areas between VMs
from xl config file" (see [1]).
And deleted some trailing white spaces.
Can you please not add unrelated changes, even if they are only white
space changes ? You can put them in a pre-patch and if you do that
please put my ack on the pre-patch :-).
+libxl_sshm_cachepolicy = Enumeration("sshm_cachepolicy", [
+ (-1, "UNKNOWN"),
+ (0, "ARM_NORMAL"), # ARM policies should be < 32
+ (32, "X86_NORMAL"), # X86 policies should be >= 32
+ ], init_val = "LIBXL_SSHM_CACHE_POLICY_UNKNOWN")
What ? Why do these need separating like that ? This is quite odd.
Caching attributes are different between Arm and x86. So we need to
provide different values for them.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
