This shell fragment lacked set -e. So, eg if the download failed a
broken ipxe.tar.gz would be left behind.
Signed-off-by: Ian Jackson <ian.jack...@eu.citrix.com>
CC: Paul Durrant <paul.durr...@citrix.com>
CC: Wei Liu <wei.l...@citrix.com>
---
tools/firmware/etherboot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/firmware/etherboot/Makefile
b/tools/firmware/etherboot/Makefile
index 3868f876ea..fd8dfdf5a7 100644
--- a/tools/firmware/etherboot/Makefile
+++ b/tools/firmware/etherboot/Makefile
@@ -33,7 +33,7 @@ $(ROM): $(ROMS)
$(MAKE) -C $D/src bin/$(*F).rom
$T:
- if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
+ set -e; if ! $(FETCHER) _$T $(IPXE_TARBALL_URL); then \
$(GIT) clone $(IPXE_GIT_URL) $D.git; \
(cd $D.git && $(GIT) archive --format=tar --prefix=$D/ \
$(IPXE_GIT_TAG) | gzip -n >../_$T); \
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
